Differential D18293

Set rows in virtualdesktop protocol
ClosedPublic
Actions

Authored by mart on Jan 16 2019, 11:28 AM.

Details

Reviewers
zzag
Group Reviewers
Plasma
KWin
Commits
R108:94e09947f2c0: Set rows in virtualdesktop protocol
Summary

Uses D17691 and sets the info on the protocol

Test Plan

correct data sent

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jan 16 2019, 11:28 AM
Restricted Application added a project: KWin. · View Herald TranscriptJan 16 2019, 11:28 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
mart requested review of this revision.Jan 16 2019, 11:28 AM
graesslin added a subscriber: graesslin.Jan 16 2019, 5:02 PM

Can't we simplify by connecting once to rowsChanged signal?

zzag added a reviewer: KWin.Jan 18 2019, 12:30 PM
zzag requested changes to this revision.Jan 18 2019, 12:36 PM
zzag added a subscriber: zzag.

Martin's comment.

This revision now requires changes to proceed.Jan 18 2019, 12:36 PM
mart updated this revision to Diff 49996.Jan 21 2019, 3:56 PM
  • use a single connection
zzag added inline comments.Jan 21 2019, 4:38 PM
virtualdesktops.cpp
81

I think it would be better to use m_virtualDesktopManagement as the context object.

zzag added inline comments.Jan 21 2019, 4:42 PM
virtualdesktops.cpp
81

Also, I think we don't need this lambda at all.

zzag added inline comments.Jan 21 2019, 5:30 PM
virtualdesktops.cpp
680

Unrelated whitespace change.

mart updated this revision to Diff 50048.Jan 22 2019, 9:29 AM
  • simpify connect
zzag accepted this revision.Jan 22 2019, 9:40 AM
This revision is now accepted and ready to land.Jan 22 2019, 9:40 AM
Closed by commit R108:94e09947f2c0: Set rows in virtualdesktop protocol (authored by mart). · Explain WhyJan 22 2019, 2:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mvirtualdesktops.cpp (2 lines)

Diff 50062

View Options

virtualdesktops.cpp

Loading...