Differential D18274

Make notifications work on Android with API level < 23
ClosedPublic
Actions

Authored by vkrause on Jan 15 2019, 6:20 PM.

Details

Reviewers
apol
Commits
R289:60dc31f81b4f: Make notifications work on Android with API level < 23
Summary

At API level < 23 we cannot set a custom icon but have to use a static one
from the Android resource system, so let's use the application icon for
that (without setting an icon Android isn't showing the notification).

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jan 15 2019, 6:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 15 2019, 6:20 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Jan 15 2019, 6:20 PM
apol accepted this revision.Jan 16 2019, 2:31 PM
This revision is now accepted and ready to land.Jan 16 2019, 2:31 PM
Closed by commit R289:60dc31f81b4f: Make notifications work on Android with API level < 23 (authored by vkrause). · Explain WhyJan 16 2019, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49655

View Options

src/android/org/kde/knotifications/NotifyByAndroid.java

Loading...