Retry for resend requests
Changes PlannedPublic

Authored by rizzitello on Jan 15 2019, 2:27 PM.

Details

Summary

Retry up to 3 times when a resend is requested from the machine

Test Plan

Check with bad commands you get a "Retry" from your machine (we may need to ignore case).

This issues seams to be exposed by D14136 more then general use.

Diff Detail

Repository
R232 AtCore
Branch
retry
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7124
Build 7142: arc lint + arc unit
rizzitello requested review of this revision.Jan 15 2019, 2:27 PM
rizzitello created this revision.
rizzitello edited the test plan for this revision. (Show Details)Jan 15 2019, 2:29 PM
rizzitello added a project: Atelier: AtCore.
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added a subscriber: Atelier: AtCore.
tcanabrava accepted this revision.Jan 16 2019, 8:46 AM
This revision is now accepted and ready to land.Jan 16 2019, 8:46 AM
patrickelectric requested changes to this revision.Jan 16 2019, 1:16 PM
patrickelectric added inline comments.
src/core/atcore.cpp
709

if( ! contains
d->ready = false
return

with this you can remove the else

This revision now requires changes to proceed.Jan 16 2019, 1:16 PM
rizzitello planned changes to this revision.Jan 16 2019, 2:22 PM

This needs to have a better check for this its not so great atm