Improve the preferences-desktop-cryptography icon
ClosedPublic

Authored by trickyricky26 on Jan 12 2019, 8:01 PM.

Details

Summary

Use the harddrive design from the drive-harddisk icon, fill the lock in the icon, adhere to the 2px margin with the 32px icons.

Test Plan

Old:

New:


At 100%:

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trickyricky26 created this revision.Jan 12 2019, 8:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 12 2019, 8:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Jan 12 2019, 8:01 PM
trickyricky26 edited the summary of this revision. (Show Details)Jan 12 2019, 8:06 PM
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 added a reviewer: VDG.
trickyricky26 edited the test plan for this revision. (Show Details)
  • Remove Plasma logo and shadow of the white label
trickyricky26 edited the test plan for this revision. (Show Details)Jan 12 2019, 8:41 PM
trickyricky26 edited the summary of this revision. (Show Details)
  • Shift the lock upwards a bit, remove bottom left shadow
trickyricky26 edited the test plan for this revision. (Show Details)Jan 12 2019, 8:55 PM
  • widen the right part of the SATA connector to be more symmterical
trickyricky26 edited the test plan for this revision. (Show Details)Jan 12 2019, 9:56 PM
ngraham requested changes to this revision.Jan 12 2019, 10:44 PM
ngraham added a subscriber: ngraham.

Much better than the original, but if we're trying to emulate the existing style, we should come as close to pixel-perfect as we can. :)

Compare your new icon to the existing preferences-system-network-iscsi icon, which uses the same style:

This revision now requires changes to proceed.Jan 12 2019, 10:44 PM
  • Match the preferences-system-network-iscsi style
trickyricky26 edited the test plan for this revision. (Show Details)Jan 13 2019, 1:11 PM

Hmm, I don't actually see any changes compares to the previous version. There are still subtle visual differences between the two icons.

  • Actually change the icon to match preferences-system-network-iscsi
trickyricky26 edited the test plan for this revision. (Show Details)Jan 13 2019, 3:41 PM
ngraham accepted this revision.Jan 13 2019, 3:45 PM

There we go!

This revision is now accepted and ready to land.Jan 13 2019, 3:45 PM
This revision was automatically updated to reflect the committed changes.