Differential D18127

[scripting] Make DBus invokable run method return result after execution
ClosedPublic
Actions

Authored by davidedmundson on Jan 9 2019, 4:00 PM.

Details

Reviewers

graesslin

Group Reviewers

KWin

Commits

R108:47be4be0209f: [scripting] Make DBus invokable run method return result after execution

Summary

In 403038 the user expected the DBus call to run to finish before
processing the next request. For a singleshot script that makes a lot of
sense, otherwise you have no idea when it finishes.

This also allows us to return errors.

CCBUG: 403038

Test Plan

NUM=$(qdbus org.kde.KWin /Scripting org.kde.kwin.Scripting.loadScript /noFile.js Minimize)
qdbus org.kde.KWin /$NUM org.kde.kwin.Scripting.run

Error: org.kde.kwin.Scripting.FileError
Could not open /noFile.js

Running a real script behaved effectively the same as before.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Jan 9 2019, 4:00 PM

Restricted Application added a project: KWin. · View Herald TranscriptJan 9 2019, 4:00 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Jan 9 2019, 4:00 PM

Harbormaster completed remote builds in B6863: Diff 49085.Jan 9 2019, 4:00 PM

graesslin accepted this revision.Jan 9 2019, 5:26 PM

This revision is now accepted and ready to land.Jan 9 2019, 5:26 PM

Is it good to go?

Closed by commit R108:47be4be0209f: [scripting] Make DBus invokable run method return result after execution (authored by davidedmundson). · Explain WhyFeb 22 2019, 2:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/CMakeLists.txt (1 line)
M			autotests/tabbox/CMakeLists.txt (2 lines)
M			scripting/scripting.h (6 lines)
M			scripting/scripting.cpp (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49085	4f62030		Jan 9 2019, 4:00 PM	★	★
Diff 2	52303	7014a33	R108:47be4be0209fd786b19c5066b96c8550a08c8746	Feb 22 2019, 2:40 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d030c3e3dd7c	4e4ff837be5b	4f620307aa8f	David Edmundson	[scripting] Make DBus invokable run method return result after execution (Show More…)	Jan 9 2019, 3:57 PM