PyFalkon build with pyside 5.12 version
AbandonedPublic

Authored by cullmann on Jan 8 2019, 9:26 AM.

Details

Reviewers
drosca
krishremya
Group Reviewers
Falkon
Summary

PyFalkon doesn't build with pyside 5.12
Bug 402947

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
krishremya created this revision.Jan 8 2019, 9:26 AM
Restricted Application added a subscriber: falkon. · View Herald TranscriptJan 8 2019, 9:26 AM
krishremya requested review of this revision.Jan 8 2019, 9:26 AM
drosca requested changes to this revision.Jan 8 2019, 9:30 AM
drosca added a subscriber: drosca.

This doesn't fix anything.

src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp: In member function ‘virtual const QMetaObject* ExternalJsObjectWrapper::metaObject() const’:
src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp:251:35: error: ‘retriveMetaObject’ is not a member of ‘PySide::SignalManager’
     return PySide::SignalManager::retriveMetaObject(reinterpret_cast<PyObject*>(pySelf));
                                   ^~~~~~~~~~~~~~~~~
src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp: In function ‘PyObject* Sbk_ExternalJsObjectFunc_registerExtraObject(PyObject*, PyObject*)’:
src/plugins/PyFalkon/PyFalkon/externaljsobject_wrapper.cpp:390:73: warning: unused parameter ‘self’ [-Wunused-parameter]
 static PyObject* Sbk_ExternalJsObjectFunc_registerExtraObject(PyObject* self, PyObject* args)
                                                               ~~~~~~~~~~^~~~
This revision now requires changes to proceed.Jan 8 2019, 9:30 AM
cullmann commandeered this revision.Fri, Apr 12, 8:05 PM
cullmann added a reviewer: krishremya.
cullmann added a subscriber: cullmann.

Please submit a new fix, if you have time.
I will close this.

cullmann abandoned this revision.Fri, Apr 12, 8:05 PM