Differential D18081

Make translations work
ClosedPublic
Actions

Authored by aacid on Jan 7 2019, 10:32 PM.

Details

Reviewers
apol
Commits
R290:2ce00422d96f: Make translations work
Summary

Do not call i18n from global static variables since qcoreapplication is
still not around yet and that makes it fail

Diff Detail

Repository
R290 KPackage
Branch
arcpatch-D18081
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6842
Build 6860: arc lint + arc unit
aacid created this revision.Jan 7 2019, 10:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 7 2019, 10:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Jan 7 2019, 10:32 PM
apol added a subscriber: apol.Jan 8 2019, 12:42 AM

LGTM otherwise

CMakeLists.txt
4 ↗(On Diff #48932)

Wrong?

aacid updated this revision to Diff 49034.Jan 8 2019, 8:21 PM

remove unrelated cmake changes

apol accepted this revision.Jan 9 2019, 12:48 AM
This revision is now accepted and ready to land.Jan 9 2019, 12:48 AM
aacid closed this revision.Jan 9 2019, 6:51 PM

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)

Diff 49034

View Options

CMakeLists.txt

Loading...