Get rid of AvailablePagesModelInterface
ClosedPublic
Actions

Authored by ervin on Jan 7 2019, 6:30 PM.

Details

Reviewers

bensi
dfaure

Commits

R4:0bbfef614176: Get rid of AvailablePagesModelInterface

Summary

This abstraction isn't necessary anymore. We also don't need to know
which features are supported since we have a fixed set of actions now.
And rename AvailableTaskPagesModel to AvailablePagesModel.

Diff Detail

Repository

R4 Zanshin

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 6768
Build 6786: arc lint + arc unit

ervin requested review of this revision.Jan 7 2019, 6:30 PM

ervin created this revision.

Harbormaster completed remote builds in B6768: Diff 48898.Jan 7 2019, 6:30 PM

dfaure accepted this revision.Jan 7 2019, 10:48 PM

This revision is now accepted and ready to land.Jan 7 2019, 10:48 PM

Closed by commit R4:0bbfef614176: Get rid of AvailablePagesModelInterface (authored by ervin). · Explain WhyJan 8 2019, 3:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/presentation/CMakeLists.txt (3 lines)
M		src/presentation/applicationmodel.h (1 line)
M		src/presentation/applicationmodel.cpp (6 lines)
V		src/presentation/{availablepagesmodel.h ← availabletaskpagesmodel.h} (42 lines)
V		src/presentation/{availablepagesmodel.cpp ← availabletaskpagesmodel.cpp} (38 lines)
D	M	src/presentation/availablepagesmodelinterface.h (66 lines)
D	M	src/presentation/availablepagesmodelinterface.cpp (32 lines)
V		src/presentation/{availabletaskpagesmodel.h → availablepagesmodel.h}
V		src/presentation/{availabletaskpagesmodel.cpp → availablepagesmodel.cpp}
M		src/widgets/availablepagesview.h (2 lines)
M		src/widgets/availablepagesview.cpp (21 lines)
M		src/zanshin/app/dependencies.cpp (18 lines)
M		tests/units/presentation/CMakeLists.txt (2 lines)
M		tests/units/presentation/applicationmodeltest.cpp (39 lines)
V		tests/units/presentation/{availablepagesmodeltest.cpp ← availabletaskpagesmodeltest.cpp} (55 lines)
M		tests/units/presentation/availablepagessortfilterproxymodeltest.cpp (2 lines)
V		tests/units/presentation/{availabletaskpagesmodeltest.cpp → availablepagesmodeltest.cpp}
M		tests/units/widgets/availablepagesviewtest.cpp (61 lines)