Remove the delegation feature
ClosedPublic
Actions

Authored by ervin on Jan 7 2019, 6:29 PM.

Details

Reviewers

bensi
dfaure

Commits

R4:6268f648311f: Remove the delegation feature

Summary

It's brittle and barely used anyway.

Diff Detail

Repository

R4 Zanshin

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 6761
Build 6779: arc lint + arc unit

ervin requested review of this revision.Jan 7 2019, 6:29 PM

ervin created this revision.

Harbormaster completed remote builds in B6761: Diff 48891.Jan 7 2019, 6:29 PM

dfaure accepted this revision.Jan 7 2019, 9:53 PM

This revision is now accepted and ready to land.Jan 7 2019, 9:53 PM

Closed by commit R4:6268f648311f: Remove the delegation feature (authored by ervin). · Explain WhyJan 8 2019, 3:13 PM

This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 101 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

		Path
M		3rdparty/kdepim/libkdepim/CMakeLists.txt (50 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/addresseelineedit.h (230 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/addresseelineedit.cpp (971 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/addresseelineedit_p.h (162 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/addresseelineedit_p.cpp (1071 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/addresseelineeditstatic.h (91 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/addresseelineeditstatic.cpp (108 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/baloocompletionemail.h (45 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/baloocompletionemail.cpp (105 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/kmailcompletion.h (87 lines)
D	M	3rdparty/kdepim/libkdepim/addressline/kmailcompletion.cpp (112 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/CMakeLists.txt (31 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailcompletiondialogtest.h (36 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailcompletiondialogtest.cpp (85 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailcompletionwidgettest.h (39 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailcompletionwidgettest.cpp (141 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemaillisttest.h (41 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemaillisttest.cpp (116 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailsearchjobtest.h (37 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailsearchjobtest.cpp (41 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailutiltest.h (39 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailutiltest.cpp (79 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailwarningtest.h (39 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/autotests/blacklistbalooemailwarningtest.cpp (71 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailcompletiondialog.h (47 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailcompletiondialog.cpp (100 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailcompletionwidget.h (72 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailcompletionwidget.cpp (280 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemaillist.h (72 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemaillist.cpp (156 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailsearchjob.h (51 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailsearchjob.cpp (62 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailutil.h (42 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailutil.cpp (65 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailwarning.h (44 lines)
D	M	3rdparty/kdepim/libkdepim/blacklistbaloocompletion/blacklistbalooemailwarning.cpp (62 lines)
D	M	3rdparty/kdepim/libkdepim/completionconfiguredialog/completionconfiguredialog.h (58 lines)
D	M	3rdparty/kdepim/libkdepim/completionconfiguredialog/completionconfiguredialog.cpp (143 lines)
D	M	3rdparty/kdepim/libkdepim/completionorder/completionordereditor.h (65 lines)
D	M	3rdparty/kdepim/libkdepim/completionorder/completionordereditor.cpp (124 lines)
D	M	3rdparty/kdepim/libkdepim/completionorder/completionorderwidget.h (108 lines)
D	M	3rdparty/kdepim/libkdepim/completionorder/completionorderwidget.cpp (443 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/addhostdialog.h (53 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/addhostdialog.cpp (204 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/kcmldap.cpp (381 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/kcmldap.desktop (79 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/kcmldap_p.h (74 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclient.h (165 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclient.cpp (299 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclient_debug.h (27 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclient_debug.cpp (22 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclientsearch.h (188 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclientsearch.cpp (426 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclientsearchconfig.h (80 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapclientsearchconfig.cpp (237 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapsearchdialog.h (119 lines)
D	M	3rdparty/kdepim/libkdepim/ldap/ldapsearchdialog.cpp (943 lines)
D	M	3rdparty/kdepim/libkdepim/libkdepim_debug.h (27 lines)
D	M	3rdparty/kdepim/libkdepim/libkdepim_debug.cpp (22 lines)
D	M	3rdparty/kdepim/libkdepim/recentaddress/recentaddressdialog.h (50 lines)
D	M	3rdparty/kdepim/libkdepim/recentaddress/recentaddressdialog.cpp (92 lines)
D	M	3rdparty/kdepim/libkdepim/recentaddress/recentaddresses.h (114 lines)
D	M	3rdparty/kdepim/libkdepim/recentaddress/recentaddresses.cpp (178 lines)
D	M	3rdparty/kdepim/libkdepim/recentaddress/recentaddresswidget.h (61 lines)
D	M	3rdparty/kdepim/libkdepim/recentaddress/recentaddresswidget.cpp (190 lines)
D	M	3rdparty/kdepim/libkdepim/tests/CMakeLists.txt (21 lines)
D	M	3rdparty/kdepim/libkdepim/tests/testaddresseelineedit.cpp (62 lines)
D	M	3rdparty/kdepim/libkdepim/tests/testldapclient.h (59 lines)
D	M	3rdparty/kdepim/libkdepim/tests/testldapclient.cpp (196 lines)
M		src/akonadi/CMakeLists.txt (2 lines)
D	M	src/akonadi/akonadimessaging.h (47 lines)
D	M	src/akonadi/akonadimessaging.cpp (80 lines)
D	M	src/akonadi/akonadimessaginginterface.h (44 lines)
D	M	src/akonadi/akonadimessaginginterface.cpp (35 lines)
M		src/akonadi/akonadiserializer.cpp (18 lines)
M		src/akonadi/akonaditaskrepository.h (7 lines)
M		src/akonadi/akonaditaskrepository.cpp (22 lines)
M		src/domain/task.h (31 lines)
M		src/domain/task.cpp (80 lines)
M		src/domain/taskrepository.h (2 lines)
M		src/presentation/artifacteditormodel.h (11 lines)
M		src/presentation/artifacteditormodel.cpp (33 lines)
M		src/presentation/metatypes.cpp (1 line)
M		src/widgets/CMakeLists.txt (2 lines)
M		src/widgets/availablesourcesview.cpp (1 line)
M		src/widgets/editorview.h (3 lines)
M		src/widgets/editorview.cpp (59 lines)
M		src/widgets/editorview.ui (145 lines)
M		src/widgets/itemdelegate.cpp (7 lines)
M		src/zanshin/app/dependencies.cpp (8 lines)
M		src/zanshin/runner/zanshinrunner.cpp (3 lines)
M		tests/features/cuke-steps.cpp (9 lines)
D	M	tests/features/zanshin/features/delegation/delegate-display.feature (11 lines)
M		tests/testlib/gentodo.h (2 lines)
M		tests/testlib/gentodo.cpp (15 lines)
M		tests/units/akonadi/akonadiserializertest.cpp (65 lines)
M		tests/units/akonadi/akonaditaskrepositorytest.cpp (74 lines)
M		tests/units/domain/tasktest.cpp (48 lines)
M		tests/units/presentation/artifacteditormodeltest.cpp (58 lines)
M		tests/units/testlib/gentodotest.cpp (24 lines)
M		tests/units/widgets/editorviewtest.cpp (150 lines)