Differential D18039

Switch to MaterialComponents theme
ClosedPublic
Actions

Authored by eduisters on Jan 7 2019, 2:21 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:72026d94bf59: Switch to MaterialComponents theme
Summary

Androidx introduced new Materialcomponents themes, use them instead of
Theme.AppCompat. This also causes AlertDialogs and PreferenceDialogFragments
to be styled correctly

BeforeAfter

(Ok button is disabled if you are wondering)

Test Plan

Apply patch, verify everything still looks as expected

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6737
Build 6755: arc lint + arc unit
eduisters created this revision.Jan 7 2019, 2:21 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJan 7 2019, 2:21 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Jan 7 2019, 2:21 PM
eduisters edited the summary of this revision. (Show Details)Jan 7 2019, 2:29 PM
eduisters added a reviewer: KDE Connect.
albertvaka accepted this revision.Jan 7 2019, 8:02 PM
This revision is now accepted and ready to land.Jan 7 2019, 8:02 PM
Closed by commit R225:72026d94bf59: Switch to MaterialComponents theme (authored by eduisters). · Explain WhyJan 8 2019, 9:08 AM
This revision was automatically updated to reflect the committed changes.
albertvaka added a comment.Jan 16 2019, 12:48 PM

Since this patch, buttons in dialog boxes have no margin on my phone:

Before:

After:

Revision Contents
Changeset List

PathPackages
Mres/values/styles-dark.xml (2 lines)
Mres/values/styles.xml (5 lines)

Diff 48863

View Options

res/values/styles-dark.xml

Loading...
View Options

res/values/styles.xml

Loading...