Catch SystemExit Exception in Scripter (Fixes #402670)
ClosedPublic

Authored by rbreu on Fri, Jan 4, 2:12 PM.

Details

Summary

This fix prevents Scripter from dying if the user calls quit() or exit(). Instead, Scripter closes itself gracefully.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rbreu created this revision.Fri, Jan 4, 2:12 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptFri, Jan 4, 2:12 PM
Restricted Application added a project: Krita. · View Herald Transcript
rbreu requested review of this revision.Fri, Jan 4, 2:12 PM
eliakinalmeida added a subscriber: eliakinalmeida.

It seems right to me. Good work, @rbreu :)

This revision is now accepted and ready to land.Fri, Jan 4, 3:53 PM
rempt added a subscriber: rempt.Fri, Jan 4, 8:44 PM

Hi Rebecca,

Have you got push access, or should we push this patch for you?

rbreu added a comment.Fri, Jan 4, 9:16 PM

I don't have push access. I should probably have mentioned that. ;)

This one I did for the documentation needs to be pushed, too:

https://phabricator.kde.org/D17701

rempt added a comment.Sat, Jan 5, 1:36 PM

Eliakin, will you push this patch this time? I'm about to start travelling.

It's ok, I can do this.

Em sáb, 5 de jan de 2019 às 10:36, Boudewijn Rempt <
noreply@phabricator.kde.org> escreveu:

rempt added a comment. View Revision https://phabricator.kde.org/D17962

Eliakin, will you push this patch this time? I'm about to start travelling.

*REPOSITORY*
R37 Krita

*REVISION DETAIL*
https://phabricator.kde.org/D17962

*To: *rbreu, Krita, eliakinalmeida
*Cc: *rempt, eliakinalmeida, jacobhe, mregdos, razcore.art, jhoolmans,
amedonosova, eoinoneill, emmetoneill, keeganh, stevenp, hellozee, jbaran,
neviril, rchakrabarti, peterkovar, zilong, razvanr, char1a, dimitard, hanu,
franciscofernandes, jose.arroyo, bruceoutdoors, qwer_ty, rjquiralta,
alvinhochun, ali-mohamed, jospin, justmesr, irinarempt, raphaelc,
nicholasl, tokiedian, Bollebib, jounip, woltherav

This revision was automatically updated to reflect the committed changes.