Add improved lesson for Italian
AbandonedPublic

Authored by simgunz on Jan 2 2019, 11:47 AM.

Details

Reviewers
gottfried
Summary

I think that the current KTouch trainer for Italian is suboptimal for the following reasons:

  • Too many letters learned at once in a lesson (up to eight per lesson!)
  • The first two lessons make the user use one single hand at the time
  • Too many lessons are mane of combination of characters instead of meaningful words (suboptimal for learning)
  • Lessons where symbols are taught include too few symbols respect the total number of typed characters

The proposed lesson fix the previous problems, in particular:

  • Only the first three lessons includes combination of characters instead of meaningful words
  • All lessons make the user use both hands
  • The lessons where symbols are thaugh include a symbol after each word
  • The new symbols represent the 50% of all the symbols in the lesson
  • Added new lessons for numbers
  • The lessons for learning symbols and numbers include words of up to seven characters to minimize the time spent on typing letters instead of symbols/numbers

The only drawback is that symbols are not learned in common phrases as the current italian lesson does,
but this provides the advantage of a more focused learning on the symbols with less time spent in typing text.

Diff Detail

Repository
R336 KTouch
Branch
course-italian
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6561
Build 6579: arc lint + arc unit
simgunz created this revision.Jan 2 2019, 11:47 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 2 2019, 11:47 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
simgunz requested review of this revision.Jan 2 2019, 11:47 AM
gottfried requested changes to this revision.Jan 2 2019, 1:30 PM

Hi Simone,

first, thanks for your contribution. New lessons are very valuable to project. While your course fixes a few shortcomings of the old lessons I don't think the old ones have no place in KTouch. Especially the later lessons with complete meaningful sentences provide good training material. For this reason I would like to ship your lessons to KTouch in addition to the current course. You don't have to prepare a patch adding your course while retaining the old one, I can do this myself. Just please fix the issues I have raised in the other comments.

data/courses/it.xml
4 ↗(On Diff #48521)

Please change to "Italian (automatically generated)" in Italian.

5 ↗(On Diff #48521)

Please translate description to Italian.

This revision now requires changes to proceed.Jan 2 2019, 1:30 PM
simgunz updated this revision to Diff 48533.Jan 2 2019, 2:41 PM
  • Fix lesson title and description

I completely agree with you, having two different lessons can be beneficial.

I would like to add few improvements to this lesson (to fix few problems I am noticing only now), so I ask you to wait before working on this review.

Alright, I will wait.

simgunz updated this revision to Diff 48542.Jan 2 2019, 3:53 PM
  • Add lesson with all accented letters, better word balance for rare words

Ok, I think it should be ok now.

  • I have added a lesson with all the accented letters in order to train with all of them together. This is necessary because words with accented letters are somehow rare, and won't be picked up frequently in the later lessons.
  • I also regenerated the lesson with an option to better balance the words when a rare letter appears with a common one in a lesson. For example now the "capitalization" lesson contains words starting with the rare letters "jkwxy". Also the lesson "wxy" should be slightly more balanced now.

I have added your course to KTouch, see https://cgit.kde.org/ktouch.git/commit/?id=8598e4af105418a92d54f5dbfbbaf04be9a492d7. It will be part of the upcoming 18.04 release.

But I haven't found an easy way to update your revision here on Phabricator. I suggest you abandon the revision here via the action menu.

Again, many thanks for your contribution.

simgunz abandoned this revision.Jan 2 2019, 8:03 PM