Differential D17828

Don't check twice if the icon exists from ::availableSizes
ClosedPublic
Actions

Authored by apol on Dec 28 2018, 3:00 AM.

Details

Reviewers
cfeck
Group Reviewers
Frameworks
Commits
R302:bc916a6be818: Don't check twice if the icon exists from ::availableSizes
Summary

It's done by iconName() as well as by the method itself.

Test Plan

Tests pass, apps still work.

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Dec 28 2018, 3:00 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 28 2018, 3:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Dec 28 2018, 3:00 AM
cfeck accepted this revision.Dec 28 2018, 3:23 AM
This revision is now accepted and ready to land.Dec 28 2018, 3:23 AM
cfeck added a comment.Dec 28 2018, 3:24 AM

Maybe add 'const found = ', while you are at it.

Closed by commit R302:bc916a6be818: Don't check twice if the icon exists from ::availableSizes (authored by apol). · Explain WhyDec 29 2018, 1:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kiconengine.cpp (2 lines)

Diff 48346

View Options

src/kiconengine.cpp

Loading...