[PanelConfigView] Set enabled borders on PanelShadow
ClosedPublic

Authored by broulik on Jun 6 2016, 12:05 PM.

Details

Summary

This fixes the panel configuration having shadows on all sides, casting a shadow onto the panel and causing an ugly glitch during the sliding animation.

Also expose the borders as property to the QML part but it doesn't use it currently.

Test Plan

Works. Requires the PanelShadows::setEnabledBorders patch in D1756

The PanelConfiguration.qml is just an Item, not a FrameSvg.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4243.Jun 6 2016, 12:05 PM
broulik retitled this revision from to [PanelConfigView] Set enabled borders on PanelShadow.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 6 2016, 12:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Jun 6 2016, 12:07 PM
mart accepted this revision.Jun 7 2016, 11:47 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jun 7 2016, 11:47 AM
This revision was automatically updated to reflect the committed changes.