Differential D17720

Allow direct link to the help page when the "Help" button is pressed in the settings window
ClosedPublic
Actions

Authored by yurchor on Dec 21 2018, 11:49 AM.

Details

Reviewers
tcanabrava
Group Reviewers
KDE Edu
Commits
R327:ed363e7b60db: Allow direct link to the help page when the Help button is pressed in the…
Summary

Since KF 5.52 it is possible (again) to open a particular page in KHelpCenter.

Test Plan

Compiles and can be run. The link in the "Configure" window ("Help" button) works as expected.

Diff Detail

Repository
R327 Kanagram
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Dec 21 2018, 11:49 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 21 2018, 11:49 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.Dec 21 2018, 11:49 AM
apol added a subscriber: apol.Dec 21 2018, 12:12 PM
apol added inline comments.
src/mainwindow.cpp
33

Use kcoreaddons_version.h

114

This looks quite dirty, maybe make it public if it needs calling from outside?

yurchor marked 2 inline comments as done.Dec 21 2018, 12:16 PM
yurchor added inline comments.
src/mainwindow.cpp
114

This breaks ABI, thus disallowed. See D17620 .

yurchor updated this revision to Diff 47949.Dec 21 2018, 12:24 PM
yurchor marked an inline comment as done.

Disallow usage of setHelp() if KAnagram is compiled with KF 5 < 5.52 even if the runtime supports it.

tcanabrava added a subscriber: tcanabrava.Dec 24 2018, 12:58 PM
tcanabrava added inline comments.
src/mainwindow.cpp
114

but this is in the main window, are we really interested in ABI there?

yurchor added inline comments.Dec 24 2018, 1:45 PM
src/mainwindow.cpp
114

Personally, as a user, I do not mind how it works if it works.

If it is better to save the current ABI then that's good for me as long as I do not have to type the code which implements it.

Sorry if that was not a question to me.

tcanabrava added inline comments.Dec 24 2018, 2:23 PM
src/mainwindow.cpp
114

It was for you.
ABI means Application Binary Interface, that means that if you change something, applications that depend on that something will break, but the MainWindow is not in a library, it's the application, so changing things inside of the application doesn't needs to keep ABI.
only in shared libraries.

yurchor added inline comments.Dec 24 2018, 2:30 PM
src/mainwindow.cpp
114

So what is the way to proceed? Rewrite this as it is in Okular (the only known semi-working implementation)?

https://cgit.kde.org/okular.git/tree/conf/preferencesdialog.cpp

Thanks in advance for your advice.

yurchor updated this revision to Diff 48848.Jan 7 2019, 8:34 AM
yurchor edited the summary of this revision. (Show Details)

Fix the right thing now.

tcanabrava accepted this revision.Jan 16 2019, 9:00 AM
This revision is now accepted and ready to land.Jan 16 2019, 9:00 AM
Closed by commit R327:ed363e7b60db: Allow direct link to the help page when the Help button is pressed in the… (authored by yurchor). · Explain WhyJan 16 2019, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kanagramconfigdialog.cpp (2 lines)
Msrc/mainwindow.cpp (1 line)

Diff 49601

View Options

src/kanagramconfigdialog.cpp

Loading...
View Options

src/mainwindow.cpp

Loading...