As discussed with Usability.
CCBUG: 363983
graesslin |
Plasma: Design | |
Plasma |
As discussed with Usability.
CCBUG: 363983
Works. Also puts a bit more usefulness in that kcm.
It's not exclusively used for keyboard shortcuts but imho fair enough given that's the thing you could pack into a concise label.
Depends on D1770
Lint Skipped |
Unit Tests Skipped |
kcms/workspaceoptions/mainpage.ui | ||
---|---|---|
60 ↗ | (On Diff #4219) | The OSD will also be triggered for things like "disable touch pad when external mouse gets connected". So that wording seems wrong to me. |
kcms/workspaceoptions/workspaceoptions.cpp | ||
55 ↗ | (On Diff #4219) | new connect syntax? (yes I am aware that changed is both a slot and a signal here and needs to be casted) |
66 ↗ | (On Diff #4219) | KSharedConfig::openConfig |
75 ↗ | (On Diff #4219) | for the readEntry you use QStringLiteral |
90 ↗ | (On Diff #4219) | QStringLiteral("OSD") is used twice in this file. Make it const static |
90 ↗ | (On Diff #4219) | as you only read from the cg you can make it const |
Martin is right, OSDs are not only about keyboard shortcuts.
They are quite difficult to describe clearly without relying on technical terms, however.
Maybe "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user interface"?
I think that's what they all have in common, because things done in the GUI should never trigger an OSD.
Can we have something more concise than "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user interface". Perhaps just "Visual feedback for status changes"?
Hm... or maybe give an example? "Visual feedback for status changes such as brightness or volume"?
I now used "Visual feedback for status changes" with a tooltip "Show a popup for status changes such as brightness or volume."
kcms/workspaceoptions/workspaceoptions.cpp | ||
---|---|---|
56–58 | why a lambda? It looks like you just could bind it to a signal |