It blocks KRunner while the application is loading and in some cases (like Kate's session selection dialog) might never return.
CCBUG: 361917
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R871:83eacf74ce6a: [Service Runner] Don't use KRun::runService
R120:83eacf74ce6a: [Service Runner] Don't use KRun::runService
Works. KRunner now always closes right away when launching the appliation rather than sometimes staying longer when the app takes a while or even never closing in case of Kate.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
This now matches what Icon is doing, but Kicker is using:
new KRun(QUrl::fromLocalFile(service->entryPath()), 0, true, ...);
This puts the kservice parsing into being done by klauncher/kinit which seems more "right".
Does using ->exec() skip the KAuthorised check?
It'll also be even faster as it'll return straight away, this still blocks a tiiiny amount until we roundtrip to kinit.