Differential D17692

Add a proper python-bytecode icon, use consistent color in python icons
ClosedPublic
Actions

Authored by trickyricky26 on Dec 19 2018, 4:05 PM.

Details

Reviewers

ngraham

Group Reviewers

VDG

Commits

R266:6baded2e1df4: Add a proper python-bytecode icon, use consistent color in python icons

Summary

BUG: 381051

FIXED-IN: 5.54

Add a separate, more recognizable icon for application-x-python-bytecode. Use a consistent, orange color for the 32px and 64px designs of application-x-python-bytecode and text-x-python.

The font used at all sizes except 64px is made of custom shapes to be as pixel-perfect as possible.

Test Plan

The new application-x-python-bytecode icons:

Consistent style for 32px and 64px application-x-python-bytecode and text-x-python:

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

trickyricky26 created this revision.Dec 19 2018, 4:05 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 19 2018, 4:05 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

trickyricky26 requested review of this revision.Dec 19 2018, 4:05 PM

Harbormaster completed remote builds in B6188: Diff 47856.Dec 19 2018, 4:05 PM

trickyricky26 edited the summary of this revision. (Show Details)Dec 19 2018, 4:11 PM

trickyricky26 edited the test plan for this revision. (Show Details)

trickyricky26 added a reviewer: VDG.

I've fixed the symlink issue in master, so now both application-x-python-bytecode and text-x-python3 are both symlinks pointing to text-x-python You'll need to re-base this patch.

Rebase on master.
Use custom shapes for the "0" and "1" in all sizes except 64px, use a consistent 45° angled line in the "0".

Harbormaster completed remote builds in B6455: Diff 48358.Dec 29 2018, 3:58 PM

trickyricky26 edited the summary of this revision. (Show Details)Dec 29 2018, 4:00 PM

trickyricky26 edited the test plan for this revision. (Show Details)

Rebase on master to work around Pahbricator bug with symlinks.

Harbormaster completed remote builds in B6458: Diff 48361.Dec 29 2018, 4:53 PM

Looks perfect!

This revision is now accepted and ready to land.Dec 29 2018, 6:22 PM

Closed by commit R266:6baded2e1df4: Add a proper python-bytecode icon, use consistent color in python icons (authored by trickyricky26, committed by ngraham). · Explain WhyDec 29 2018, 6:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	icons-dark/mimetypes/16/application-x-python-bytecode.svg (1 line)
M		icons-dark/mimetypes/16/text-x-python.svg (4 lines)
A	M	icons-dark/mimetypes/22/application-x-python-bytecode.svg (1 line)
M		icons-dark/mimetypes/22/text-x-python.svg (86 lines)
A	M	icons-dark/mimetypes/32/application-x-python-bytecode.svg (1 line)
M		icons-dark/mimetypes/32/text-x-python.svg (29 lines)
A	M	icons-dark/mimetypes/64/application-x-python-bytecode.svg (1 line)
M		icons-dark/mimetypes/64/text-x-python.svg (27 lines)
A	M	icons/mimetypes/16/application-x-python-bytecode.svg (1 line)
M		icons/mimetypes/16/text-x-python.svg (4 lines)
A	M	icons/mimetypes/22/application-x-python-bytecode.svg (1 line)
M		icons/mimetypes/22/text-x-python.svg (86 lines)
A	M	icons/mimetypes/32/application-x-python-bytecode.svg (1 line)
M		icons/mimetypes/32/text-x-python.svg (136 lines)
A	M	icons/mimetypes/64/application-x-python-bytecode.svg (1 line)
M		icons/mimetypes/64/text-x-python.svg (217 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47856	5007791		Dec 19 2018, 4:05 PM	★	★
Diff 2	48358	9ef8e48	Use custom shapes for the "0" and "1" in all sizes except `64px`, use a…	Dec 29 2018, 3:58 PM	★	★
Diff 3	48361	7f04faf	Rebase on master to work around Pahbricator bug with symlinks.	Dec 29 2018, 4:53 PM	★	★
Diff 4	48365	7f04faf	R266:6baded2e1df4e1ca08a670ef73cd1da02e726f12	Dec 29 2018, 6:23 PM	★	★