Proper removal of existing jobs by the Mosaic Tool
ClosedPublic

Authored by TallFurryMan on Dec 19 2018, 3:46 PM.

Details

Summary

When the Mosaic tool offers to delete existing jobs, it may incorrectly remove its own new jobs.
Evaluation occurs at each job insertion, so new jobs may be reordered in the middle of existing jobs.
Therefore, if requested to remove existing jobs, do this before adding mosaic jobs, not after.

Test Plan

Create and add a scheduler job, then open the Mosaic Tool.
Configure the Mosaic Tool, request it to create the new jobs.
When asked whether to keep existing jobs, select "No".

Repeat the test with:

  • No scheduler job selected
  • The new scheduler job selected
  • Option "Reorder jobs per altitude and priority" enabled

Without the change, some new jobs may be deleted and not make it in the final list, while old ones may be kept.
With the change, existing jobs are properly removed before adding new ones.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Dec 19 2018, 3:46 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 19 2018, 3:46 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Dec 19 2018, 3:46 PM
mutlaqja accepted this revision.Dec 19 2018, 4:02 PM
This revision is now accepted and ready to land.Dec 19 2018, 4:02 PM
This revision was automatically updated to reflect the committed changes.