checkXML5 index.docbook
Details
Details
- Reviewers
yurchor - Group Reviewers
Documentation - Commits
- R358:7c7d2c622573: Update screenshots of the handbook.
R358:94b3bef75368: Update screenshots of the handbook.
Diff Detail
Diff Detail
- Repository
- R358 KGpg
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Just to be sure, should I wait for the group reviewer "documentation" to approve or directly push this patch.
Comment Actions
It is obvious that the screenshots were updated correctly. I see no reason for not pushing them now.
Just some nitpicks:
- They can be pushed into Applications/18.12 branch as well.
- They can be compressed with advpng -z4 , but it is not a requirement.
| doc/editor.png | ||
|---|---|---|
| 1 | Please try if you can encrypt a shorter text so the vertical space in the handbook does not needlessly increase. | |
| doc/keymanage.png | ||
| 1 ↗ | (On Diff #47851) | I made sure to have permission from Pino before doing the screenshot. Please make sure you have the permission of the key owners or use mine and Pinos key. |
Comment Actions
- Remove some name fron screenshot for keymanage.png
- Create a smaller screenshot for editor.png
| doc/keymanage.png | ||
|---|---|---|
| 1 ↗ | (On Diff #47851) | Thanks, didn't cross my mind then I took the screenshot. |
| doc/keymanage.png | ||
|---|---|---|
| 1 ↗ | (On Diff #47887) | I would welcome some more things showing up in the new screenshot as it was in the old one: different key trust levels (that's why I had the CA keys in there, which I had signed for that), subids/signatures, also ones without associated key, and the context menu. |
| doc/keymanage.png | ||
|---|---|---|
| 1 ↗ | (On Diff #47887) | No problem, I can do that. |