Differential D17642

remove binding loop in KickoffItem
ClosedPublic
Actions

Authored by davidedmundson on Dec 17 2018, 6:42 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:be189b0ce2b7: remove binding loop in KickoffItem
Summary

For non-wrapped text, implicitHeight will be the height of the
paintedText. The key difference is it won't re-evaluate except on text
changing which removes the binding loop.

BUG: 402252

Test Plan

Opened kickoff
Looked identical
No more warnings

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 17 2018, 6:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 17 2018, 6:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 17 2018, 6:42 PM
broulik accepted this revision.Dec 18 2018, 12:27 PM
This revision is now accepted and ready to land.Dec 18 2018, 12:27 PM
Closed by commit R119:be189b0ce2b7: remove binding loop in KickoffItem (authored by davidedmundson). · Explain WhyDec 19 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47837

View Options

applets/kickoff/package/contents/ui/KickoffItem.qml

Loading...