Details
Diff Detail
- Repository
- R866 KDevelop Rust Support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Please rephrase your commit message to indicate what you are fixing. This seems to be a change that fixes a minor performance paper cut, right?
@mwolff No, it's not to improve performance. This project will not be built without these changes.
createCompletionContext is an override function, so its definition must correspond with the original one from /usr/include/kdevplatform/language/codecompletion/codecompletionworker.h.
Referrence：
https://github.com/KDE/kdevelop/blob/master/kdevplatform/language/codecompletion/codecompletionworker.h#L82
https://github.com/KDE/kdevelop/blob/master/kdevplatform/language/codecompletion/codecompletionworker.cpp#L141
See, that's why the commit message should be rephrased :)
Also, add the missing "override" keyword to make it clear that this overrides a function (and thus needs to match the signature)
Wouldn't that be an opportunity to add the override specifier? The commit message could state "Fix function signature of ... to override".
lgtm now, sorry for the delay - can you push that yourself? if not, please tell us your email address and name to associate with the commit
thanks