People myang

myang (Michael Yang)
User

Projects

User does not belong to any projects.

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 16 2018, 4:35 AM (279 w, 4 d)
Availability
Available

Recent Activity
View All

Dec 27 2018

myang added a comment to D17618: Fix override function signature of createCompletionContext().

@mwolff ?

Dec 27 2018, 3:25 AM · KDevelop

Dec 22 2018

myang added a comment to D17618: Fix override function signature of createCompletionContext().

@mwolff Still "Needs Revision", is the commit message not accurate enough?

Dec 22 2018, 2:56 AM · KDevelop

Dec 17 2018

myang added a comment to D17618: Fix override function signature of createCompletionContext().

@mwolff Done.

Dec 17 2018, 10:15 AM · KDevelop
myang retitled D17618: Fix override function signature of createCompletionContext() from Fix definition of createCompletionContext() to Fix override function signature of createCompletionContext().
Dec 17 2018, 10:12 AM · KDevelop
myang retitled D17618: Fix override function signature of createCompletionContext() from Fix createCompletionContext to Fix definition of createCompletionContext().
Dec 17 2018, 9:16 AM · KDevelop
myang added a comment to D17618: Fix override function signature of createCompletionContext().

@mwolff No, it's not to improve performance. This project will not be built without these changes.
createCompletionContext is an override function, so its definition must correspond with the original one from /usr/include/kdevplatform/language/codecompletion/codecompletionworker.h.

Dec 17 2018, 9:07 AM · KDevelop

Dec 16 2018

myang requested review of D17618: Fix override function signature of createCompletionContext().
Dec 16 2018, 5:07 AM · KDevelop