Instead of calculating them over and over again in response to various geometry change events, just use the newly introduced property.
Details
Details
- Reviewers
davidedmundson mart - Group Reviewers
Plasma - Commits
- R119:b003ca6b79a0: [Panel] Reduce duplicate enabled borders calculation
Requires D1756
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| desktoppackage/contents/views/Panel.qml | ||
|---|---|---|
| 29 ↗ | (On Diff #4189) | In PanelView::themeChanged call positionPanel() and then we can get rid of this. |
Comment Actions
I don't understand what the patch is supposed to be doing.. the enabled bprders of the svg can be calculated only based on the location of the panel, that has been completely removed
| desktoppackage/contents/views/Panel.qml | ||
|---|---|---|
| 29 ↗ | (On Diff #4189) | this is used on themes that have different svgs for different panel locations ( default ones don't anymore) should be found some obscure theme on kdelook that uses this feature (i can see an use for it, don't think it can be removed to force only one background per theme) |
| 32 ↗ | (On Diff #4189) | there is no enabledborders property in containment? (neither i want such a property, is not the right place) |
| desktoppackage/contents/views/Panel.qml | ||
|---|---|---|
| 32 ↗ | (On Diff #4189) | perhaps as a property of the view could work |
| desktoppackage/contents/views/Panel.qml | ||
|---|---|---|
| 32 ↗ | (On Diff #4189) | Ah yeah, it's not on containment, I put it on panel. yay for testing my patches :D |
| desktoppackage/contents/views/Panel.qml | ||
|---|---|---|
| 29 ↗ | (On Diff #4189) | ok |