Add dependency on kirigami to SMS app

Authored by sredman on Dec 13 2018, 8:50 PM.



Resolves Bug 401255

Bonus: Disable some very noisy debugging from the SMS app

Test Plan
  • Build KDE Connect with or without Kirigami
    • Verify successful build with no complaints about Kirigami
  • Build KDE Connect's Messenger:
    • Without Kirigami: Verify that CMake warns that Kirigami is not found
    • With Kirigami: Verify that app launches successfully

Diff Detail

R224 KDE Connect
Lint OK
No Unit Test Coverage
Build Status
Buildable 6005
Build 6023: arc lint + arc unit
sredman created this revision.Dec 13 2018, 8:50 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 13 2018, 8:50 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Dec 13 2018, 8:50 PM
sredman edited the summary of this revision. (Show Details)Dec 13 2018, 8:51 PM
sredman added a subscriber: apol.
sredman added inline comments.

@apol Please lend your QML experience:

  • Do you know why the app on master is currently set to require QQC v2.4?
  • If I change the version of a QML library and the app launches and runs correctly, does that mean everything is fine?
nicolasfella accepted this revision.Jan 24 2019, 9:12 AM
This revision is now accepted and ready to land.Jan 24 2019, 9:12 AM
sredman closed this revision.Jan 24 2019, 5:40 PM