Add dependency on kirigami to SMS app
ClosedPublic
Actions

Authored by sredman on Dec 13 2018, 8:50 PM.

Details

Reviewers

nicolasfella

Group Reviewers

KDE Connect

Commits

R224:3b92b0de1d57: Add dependency on kirigami to SMS app

Summary

Resolves Bug 401255

Bonus: Disable some very noisy debugging from the SMS app

Test Plan

Build KDE Connect with or without Kirigami
- Verify successful build with no complaints about Kirigami
Build KDE Connect's Messenger:
- Without Kirigami: Verify that CMake warns that Kirigami is not found
- With Kirigami: Verify that app launches successfully

Repository

R224 KDE Connect

Branch

smsapp-depends

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 6005
Build 6023: arc lint + arc unit

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

sredman requested review of this revision.Dec 13 2018, 8:50 PM

sredman added a subscriber: apol.

sredman added inline comments.

smsapp/qml/ConversationDisplay.qml
22	@apol Please lend your QML experience: Do you know why the app on master is currently set to require QQC v2.4? If I change the version of a QML library and the app launches and runs correctly, does that mean everything is fine?