[PanelView] Expose enabled borders as property and also forward it to PanelShadows
ClosedPublic

Authored by broulik on Jun 3 2016, 10:48 AM.

Details

Summary

I noticed that panels had borders on all sides and it turns out PanelShadows was never actually told which sides should have shadows. To reduce code duplication I expose the enabled borders as property to the Panel.qml which itself does the same calculation from QML again and does it many times.

Test Plan

Moved panels around a bit, didn't notice breakage, but there might be.
I no longer have panel shadows bleeding onto other screens.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 4188.Jun 3 2016, 10:48 AM
broulik retitled this revision from to [PanelView] Expose enabled borders as property and also forward it to PanelShadows.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 3 2016, 10:48 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jun 6 2016, 8:19 AM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jun 6 2016, 8:19 AM
This revision was automatically updated to reflect the committed changes.