Differential D17567

TabSwitcherPlugin: Suppress CMP0063 warning with CMake >= 3.3
ClosedPublic
Actions

Authored by loh.tar on Dec 13 2018, 4:43 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Dec 13 2018, 4:43 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 13 2018, 4:43 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Dec 13 2018, 4:43 PM
loh.tar added a comment.Dec 13 2018, 4:55 PM


So far I understand this, may there a real fix for this needed

dhaumann added a subscriber: dhaumann.Dec 19 2018, 6:53 AM

What is the cmake warning about? Is there another fix without disabling warnings?

loh.tar added a comment.Dec 19 2018, 2:20 PM

You may run cmake --help-policy CMP0063
I had found this Q/A https://stackoverflow.com/a/33209064 and didn't try to understand what all is about :-)

cullmann accepted this revision.Dec 26 2018, 9:41 PM
cullmann added a subscriber: cullmann.

Hmm, actually I think we can just cleanup the CMakeLists.txt ;=)
I will push a change.

This revision is now accepted and ready to land.Dec 26 2018, 9:41 PM
cullmann closed this revision.Dec 26 2018, 9:43 PM

Upsa, used wrong number :?)

Git commit 02f20c0c18480a56ff9a6acf7d5bcfefc59e829d by Christoph Cullmann.
Committed on 26/12/2018 at 21:42.
Pushed by cullmann into branch 'master'.

fix cmake warning

Differential Revision: https://phabricator.kde.org/D17733

M +3 -22 addons/tabswitcher/tests/CMakeLists.txt

https://commits.kde.org/kate/02f20c0c18480a56ff9a6acf7d5bcfefc59e829d

diff --git a/addons/tabswitcher/tests/CMakeLists.txt b/addons/tabswitcher/tests/CMakeLists.txt
index 82a66b5c2..df88775c9 100644

  • a/addons/tabswitcher/tests/CMakeLists.txt

+++ b/addons/tabswitcher/tests/CMakeLists.txt
@@ -1,22 +1,3 @@
-cmake_minimum_required(VERSION 3.0.0)
-project(tstestapp)

    • Find includes in corresponding build directories

-set(CMAKE_INCLUDE_CURRENT_DIR ON)

  • Instruct CMake to run moc automatically when needed.

-set(CMAKE_AUTOMOC ON)

    • Find the QtWidgets library

-find_package(Qt5Widgets CONFIG REQUIRED)

-set(SRC

  • tstestapp.cpp
  • ../tabswitcherfilesmodel.cpp

-)

-add_executable(tstestapp ${SRC})
-target_link_libraries(tstestapp

  • Qt5::Widgets
  • KF5::TextEditor

-)

+# small test for the tabswitches
+add_executable(tstestapp tstestapp.cpp ../tabswitcherfilesmodel.cpp)
+target_link_libraries(tstestapp KF5::TextEditor)

Revision Contents
Changeset List

Diff 47529

View Options

addons/tabswitcher/tests/CMakeLists.txt

Loading...