| aacid |
| KDE Games |
the only remaining use was klocale:
builds + loads correct default language based on what is configured in systemsettings + language list looks somewhat sane
| No Linters Available |
| No Unit Test Coverage |
| Buildable 8674 | |
| Build 8692: arc lint + arc unit |
I don't want the language name regression.
You're welcome to pickup https://phabricator.kde.org/D10446 if you have time.
Fair enough. If you tell me what needs doing I can poke it. I don't want to invest too much time, but at a glance what you have done seems pretty much done really.
Now that KLanguageName is landed: do you want to ifdef and retain compatibility with older KF5s or bump the required version?
Let's just get rid of it altogether, it's going to be a bit painful do an if version in cmake
| toplevel.cpp | ||
|---|---|---|
| 236 ↗ | (On Diff #52044) | this is wrong, you moved the language.isEmpty up and now the else triggers in cases it should not trigger. |
| toplevel.cpp | ||
|---|---|---|
| 236 ↗ | (On Diff #52044) | Hm. That is true. Truth be told even after pointing that out it still took me way to long to see the problem -.- I think I wanted to avoid the extra level of nesting. With that motivation in mind, what do you think about splitting the if if (soundEnabled && language.isEmpty())
{
const QStringList &systemLanguages = KLocalizedString::languages();
....
}
if (!soundEnabled)
{
soundOff();
language = QString();
}In my mind the two code blocks aren't two sides of the same coin. One is language fallback-handling the other is the unrelated disabling of all sound. The only thing that links them is the fact that the only thing language is used for is to figure out what sound set to use. I don't mind particularly though, so if you'd like to have if (soundEnabled) {
if (language.isEmpty()) { ... }
} else { ... }I'm fine with that too |
| toplevel.cpp | ||
|---|---|---|
| 236 ↗ | (On Diff #52044) | Not attached to any solution, just want one that works :) |
fix broken conditional. sound disabling condition is now detatched from the language fallback condition