Differential D17551

Take the scrollbar into account for the ScrollablePage margin
ClosedPublic
Actions

Authored by apol on Dec 13 2018, 3:43 AM.

Details

Reviewers
mart
ngraham
Group Reviewers
Kirigami
Commits
R169:582721206a03: Take the scrollbar into account for the ScrollablePage margin
Summary

BUG: 401972

Test Plan

Now I never get that overlapping, it could have other ramifications though.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5975
Build 5993: arc lint + arc unit
apol created this revision.Dec 13 2018, 3:43 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 13 2018, 3:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Dec 13 2018, 3:43 AM
ngraham added a subscriber: ngraham.Dec 13 2018, 3:05 PM

This fixes the issue in Discover for me and doesn't seem to regress anything in Gallery.

ngraham accepted this revision.Dec 13 2018, 3:05 PM
This revision is now accepted and ready to land.Dec 13 2018, 3:05 PM
mart accepted this revision.Dec 13 2018, 3:10 PM
apol closed this revision.Dec 13 2018, 3:36 PM

Revision Contents
Changeset List

PathPackages
Msrc/controls/ScrollablePage.qml (3 lines)

Diff 47484

View Options

src/controls/ScrollablePage.qml

Loading...