Differential D17549

We are not linking against dbus when building kstars lite
AbandonedPublic
Actions

Authored by apol on Dec 12 2018, 11:41 PM.

Details

Reviewers
mutlaqja
Group Reviewers
KStars
Summary

This fixes the build on Android

Diff Detail

Repository
R321 KStars
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5973
Build 5991: arc lint + arc unit
apol created this revision.Dec 12 2018, 11:41 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 12 2018, 11:41 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
apol requested review of this revision.Dec 12 2018, 11:41 PM
mutlaqja added a subscriber: mutlaqja.Dec 13 2018, 5:26 AM

I believe it also needs to be added to fov.cpp since DBus stuff are there.

mutlaqja requested changes to this revision.Dec 13 2018, 5:27 AM
This revision now requires changes to proceed.Dec 13 2018, 5:27 AM
apol added a comment.Dec 13 2018, 1:51 PM

Then why does it build? Maybe fov.cpp isn't built on Android?

mutlaqja added a comment.Dec 13 2018, 3:15 PM

Can you please check if 261fefea2442f648e0c60de1cfb6ad34229b0184 fixes the issue?

apol added a comment.Dec 13 2018, 5:10 PM

Looks promising, just triggered a build.
https://binary-factory.kde.org/view/Android/job/KStars_android/

You can trigger builds too. (and if you can't, ask sysadmin)

mutlaqja resigned from this revision.Jan 5 2019, 6:24 AM

A solution was merged already.

apol abandoned this revision.Feb 15 2019, 3:43 PM

Revision Contents
Changeset List

PathPackages
Mkstars/auxiliary/fov.h (4 lines)

Diff 47480

View Options

kstars/auxiliary/fov.h

Loading...