Differential D17531

Don't exec() hint about deactivating URL grabber
ClosedPublic
Actions

Authored by broulik on Dec 12 2018, 10:03 AM.

Details

Reviewers
davidedmundson
graesslin
Group Reviewers
Plasma
Commits
R120:fb918b6440ce: Don't exec() hint about deactivating URL grabber
Summary

Nested event loops in conjunction with QML are dangerous.
Port to QMessageBox which can be used without exec()

BUG: 363771

Test Plan

5.12? 5.14? master?

  • Pressed Ctrl+Alt+X to enable the URL grabber, selected a URL in the browser:
  • Plasma stay interactive
  • Doesn't crash anymore
  • Text still translated (ie. didn't break the translation)
  • Doesn't make a "ding" sound anymore but I didn't find a way to use KMessageBox without exec()

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 12 2018, 10:03 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 12 2018, 10:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 12 2018, 10:03 AM
davidedmundson accepted this revision.Dec 12 2018, 2:18 PM
This revision is now accepted and ready to land.Dec 12 2018, 2:18 PM
Closed by commit R120:fb918b6440ce: Don't exec() hint about deactivating URL grabber (authored by broulik). · Explain WhyDec 12 2018, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mklipper/klipper.cpp (10 lines)

Diff 47459

View Options

klipper/klipper.cpp

Loading...