BrightScript: Add workaround for QtCreator 'endsub' highlighting
ClosedPublic

Authored by dlevin on Dec 12 2018, 4:37 AM.

Details

Summary

QtCreator requires that keyword should be wrapped with white spaces on
both ends. Kate requires only trailing white space after keyword. This
patch replaces detection of 'endsub' and 'endfunction' with
StringDetect instead of keyword to satisfy both.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dlevin created this revision.Dec 12 2018, 4:37 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 12 2018, 4:37 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dlevin requested review of this revision.Dec 12 2018, 4:37 AM
cullmann accepted this revision.Dec 12 2018, 7:22 PM

If that helps the QtCreator implementation, I am ok with it, thought I would like to see that they use the framework :P

This revision is now accepted and ready to land.Dec 12 2018, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Yeah, this might be another bug in the QtCreator (already fixed one crash in their highlighting implementation). They asked me to not put much effort because that code it deprecated anyway in favor or KDE lib. But they just released Creator 4.8.0 and I do not expect any major updates in the nearest feature. So providing simple workaround in the XML should be good enough. Thanks for the quick review as always!