dlevin (Daniel Levin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 5 2018, 3:18 AM (284 w, 1 d)
Availability
Available

Recent Activity

Feb 21 2019

dlevin added a comment to D19198: BrightScript: Unary and hex numbers, @attribute.

Thanks for cleaning up the tests after me!

Feb 21 2019, 8:54 PM · Frameworks, Kate
dlevin requested review of D19198: BrightScript: Unary and hex numbers, @attribute.
Feb 21 2019, 10:34 AM · Frameworks, Kate

Dec 12 2018

dlevin added a comment to D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting.

Yeah, this might be another bug in the QtCreator (already fixed one crash in their highlighting implementation). They asked me to not put much effort because that code it deprecated anyway in favor or KDE lib. But they just released Creator 4.8.0 and I do not expect any major updates in the nearest feature. So providing simple workaround in the XML should be good enough. Thanks for the quick review as always!

Dec 12 2018, 7:55 PM · Frameworks, Kate
dlevin requested review of D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting.
Dec 12 2018, 4:37 AM · Frameworks, Kate

Dec 11 2018

dlevin added a comment to D17436: BrightScript: Remove unused keyword list 'end'.

Thanks for the fix, yes it is valid. Previously "end" was used as a standalone keyword, but keyword requires space after the word. Now it used in StringDetect to detect cases like "end sub" and "endsub" in the same rule.

Dec 11 2018, 6:21 AM · Frameworks, Kate

Dec 2 2018

dlevin updated the diff for D17295: BrightScript: Add function/sub folding.

Increased version number.

Dec 2 2018, 6:52 AM · Frameworks, Kate
dlevin requested review of D17295: BrightScript: Add function/sub folding.
Dec 2 2018, 6:42 AM · Frameworks, Kate

Nov 30 2018

dlevin added a comment to D17204: BrightScript: Allow sub to be unnamed.

This language does not have folding test. I did not provide validation for it before. Should I do that?

Nov 30 2018, 7:29 PM · Frameworks, Kate

Nov 28 2018

dlevin added a comment to D17204: BrightScript: Allow sub to be unnamed.

Thanks for the review. Btw, is there any chance to preserve my name/email in the final commit?

Nov 28 2018, 6:45 AM · Frameworks, Kate
dlevin updated the diff for D17204: BrightScript: Allow sub to be unnamed.
Nov 28 2018, 6:44 AM · Frameworks, Kate
dlevin requested review of D17204: BrightScript: Allow sub to be unnamed.
Nov 28 2018, 5:00 AM · Frameworks, Kate

Nov 11 2018

dlevin added a comment to D16677: Add BrightScript syntax.

Thanks for catching this. Did re-run tests locally, seems no other issue remaining. Please check.

Nov 11 2018, 5:46 AM · Frameworks, Kate
dlevin updated the diff for D16677: Add BrightScript syntax.

Replaced missing "code" attribute with "g".

Nov 11 2018, 5:45 AM · Frameworks, Kate

Nov 10 2018

dlevin added a comment to D16677: Add BrightScript syntax.

You can find my credentials at the beginning of the file I added in this patch: data/syntax/brightscript.xml

Nov 10 2018, 4:03 PM · Frameworks, Kate
dlevin added a comment to D16677: Add BrightScript syntax.

@ngraham, so I have to match commit authors in syntax-highlighting Git project against that list? Curious whether all those people have rights to push patches particularly into this project. Still it feels like this is not an easy task to do that manually, so I would rather annoy you guys in this message thread with my push request (-:

Nov 10 2018, 6:51 AM · Frameworks, Kate

Nov 9 2018

dlevin added a comment to D16677: Add BrightScript syntax.

Thanks a lot for helping me with this! One last question: how do I know that patch was finally merged, by periodically checking the github mirror git repository? https://github.com/KDE/syntax-highlighting.git

Nov 9 2018, 7:50 PM · Frameworks, Kate
dlevin added a comment to D16677: Add BrightScript syntax.

I do not have a KDE commit account, so I guess I need your help to integrate this patch.

Nov 9 2018, 5:46 PM · Frameworks, Kate
dlevin added a comment to D16677: Add BrightScript syntax.

Just double checking whether any additional actions required from my side or 'landing' a patch means it will be a part of the next release automatically.
If so then where I could find a release roadmap?
Thanks in advance!

Nov 9 2018, 1:59 AM · Frameworks, Kate

Nov 5 2018

dlevin added a comment to D16677: Add BrightScript syntax.

There are various reasons I was using 1-element keyword lists instead of StringDetect:

  1. keyword properly recognizes value surrounded by non-word characters, StringDetect does not.
  2. BrightScript language is case insensitive, adding insensitive="true" to every single StringDetect is too verbose in my case.
Nov 5 2018, 8:45 AM · Frameworks, Kate
dlevin updated the diff for D16677: Add BrightScript syntax.

Changed syntax license to MIT.

Nov 5 2018, 7:35 AM · Frameworks, Kate
dlevin requested review of D16677: Add BrightScript syntax.
Nov 5 2018, 3:23 AM · Frameworks, Kate