Xdg Decoration Support
ClosedPublic

Authored by davidedmundson on Dec 11 2018, 8:41 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R127:46390781daad: Xdg Decoration Support
Summary

Usual massive boilerplate.

Should allow us to remove the injection in our QPT, as Qt 5.12 implements
this protocol directly. Will probably be relevant for other toolkits as
it's more standardised than our custom one.

Client is mostly 1:1 with the protocol, server side has some tweaking to
fit with kwayland turning an event based API into a state based one.

Test Plan

Relevant unit test
Tried in modified kwin with our QPT disabled

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 11 2018, 8:41 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 11 2018, 8:41 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 11 2018, 8:41 AM
zzag added a subscriber: zzag.Dec 11 2018, 9:39 AM
zzag added inline comments.
autotests/client/test_xdg_decoration.cpp
179–182

Do we actually use it?

220

Please delete it or provide useful output.

238

Same here.

src/client/registry.h
665

since 5.54?

1724

Typo: manger

misc cleanups

zzag's comments

davidedmundson marked 5 inline comments as done.Dec 11 2018, 10:30 AM
zzag added inline comments.Dec 11 2018, 10:56 AM
autotests/client/test_xdg_decoration.cpp
105

Do we need this spy?

remove unused

zzag accepted this revision.Dec 12 2018, 5:21 PM
This revision is now accepted and ready to land.Dec 12 2018, 5:21 PM
This revision was automatically updated to reflect the committed changes.