A minor bug in ipv4 and ipv6 test
ClosedPublic
Actions

Authored by pranavgade on Dec 10 2018, 11:59 AM.

Details

Reviewers

jgrulich

Commits

R282:2edc30be9f3e: A minor bug in ipv4 and ipv6 test

Summary

Some QCOMPAREs were comparing a value in a map with itself.
Fixed.

Repository

R282 NetworkManagerQt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

pranavgade requested review of this revision.Dec 10 2018, 11:59 AM

This revision is now accepted and ready to land.Dec 10 2018, 12:02 PM

This change causes the ipv4 address test to fail due to a difference in size of list.
[F6468448]

This revision was automatically updated to reflect the committed changes.

In D17474#374522, @pranavgade wrote:

This change causes the ipv4 address test to fail due to a difference in size of list.
[F6468448]

			Path	Packages
M			autotests/settings/ipv4settingtest.cpp (8 lines)
M			autotests/settings/ipv6settingtest.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47268			Dec 10 2018, 11:57 AM	★	★
Diff 2	47269	51c4f3c	R282:2edc30be9f3e3755550800320a31791f7003dd89	Dec 10 2018, 12:03 PM	★	★