[libinput] Properly handle threaded Device creation
ClosedPublic

Authored by graesslin on Jun 2 2016, 11:21 AM.

Details

Summary

Device is created from Connection::processEvents which is run in the
main gui thread, while Connection itself is in a different thread. Thus
passing *this* as parent is wrong.

This change removes the parent, moves the created Device into the
Connection thread and also deletes properly by using deleteLater.

Diff Detail

Repository
R108 KWin
Branch
libinput-device-thread-parent
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 4162.Jun 2 2016, 11:21 AM
graesslin retitled this revision from to [libinput] Properly handle threaded Device creation.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 2 2016, 11:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.Jun 2 2016, 2:16 PM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.

retried, warnings gone now.

This revision is now accepted and ready to land.Jun 2 2016, 2:16 PM
This revision was automatically updated to reflect the committed changes.