KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots

Authored by rjvbb on Dec 9 2018, 10:06 PM.



This adds 2 missing slots to the KTextEditorPlugin integration layer: MainWindow::openUrl() and MainWindow::showToolView().

See D16779

Test Plan

Works as intended on Mac and Linux.

I'm not entirely convinced about showToolView(). It works but only if the toolview in question was already added to a toolview dock at launch.
I've considered making the slot a stub that simply returns false, but wanted to present a working alternative first.

Diff Detail

R32 KDevelop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
rjvbb requested review of this revision.Dec 9 2018, 10:06 PM
rjvbb created this revision.
rjvbb edited the test plan for this revision. (Show Details)Dec 10 2018, 9:40 AM
rjvbb added a comment.Dec 11 2018, 3:33 PM

No objections?

apol accepted this revision.Dec 13 2018, 7:24 PM
apol added a subscriber: apol.


This revision is now accepted and ready to land.Dec 13 2018, 7:24 PM
This revision was automatically updated to reflect the committed changes.