Differential D1746

[libinput] Properly handle threaded Device creation
ClosedPublic
Actions

Authored by graesslin on Jun 2 2016, 11:21 AM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R108:9b187f8a3b99: [libinput] Properly handle threaded Device creation
Summary

Device is created from Connection::processEvents which is run in the
main gui thread, while Connection itself is in a different thread. Thus
passing *this* as parent is wrong.

This change removes the parent, moves the created Device into the
Connection thread and also deletes properly by using deleteLater.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4162.Jun 2 2016, 11:21 AM
graesslin retitled this revision from to [libinput] Properly handle threaded Device creation.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 2 2016, 11:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.Jun 2 2016, 2:16 PM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.

retried, warnings gone now.

This revision is now accepted and ready to land.Jun 2 2016, 2:16 PM
Closed by commit R108:9b187f8a3b99: [libinput] Properly handle threaded Device creation (authored by graesslin). · Explain WhyJun 2 2016, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibinput/connection.cpp (6 lines)

Diff 4164

View Options

libinput/connection.cpp

Loading...