Make DeviceFragments listview use full screen width so the over scroll indicator looks better
ClosedPublic
Actions

Authored by eduisters on Dec 9 2018, 5:20 PM.

Details

Reviewers

nicolasfella

Group Reviewers

KDE Connect

Commits

Summary

Make DeviceFragments listview use full screen width so the over scroll indicator looks better


before	after

Test Plan

Apply patch and notice that the layout of the list elements has remained the same as before

Repository

R225 KDE Connect - Android application

Branch

fullwidth_list_view

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5857
Build 5875: arc lint + arc unit

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

eduisters requested review of this revision.Dec 9 2018, 5:20 PM

Cool!

This revision is now accepted and ready to land.Dec 9 2018, 5:40 PM

This revision was automatically updated to reflect the committed changes.

			Path
A	M	(img)	res/drawable-hdpi/divider_horizontal_holo_light.9.png
A	M		res/drawable-v21/list_divider.xml (6 lines)
A	M		res/drawable/list_divider.xml (6 lines)
M			res/layout/activity_device.xml (28 lines)
M			res/layout/list_item_with_icon_entry.xml (83 lines)
M			src/org/kde/kdeconnect/UserInterface/DeviceFragment.java (5 lines)
V			src/org/kde/kdeconnect/UserInterface/{ → List}/FailedPluginListItem.java
V			src/org/kde/kdeconnect/UserInterface/{List ← }/FailedPluginListItem.java (9 lines)
M			src/org/kde/kdeconnect/UserInterface/List/SmallEntryItem.java (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47192	89cbdac		Dec 9 2018, 5:19 PM	★	★
Diff 2	47200	87ec4f2	R225:15ff0fca2b56c18e0dd5a88f030d8809d52fcad4	Dec 9 2018, 5:55 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b75770c426ae	1842e508142d	89cbdac01091	Erik Duisters	Make DeviceFragments listview use full screen width so the over scroll… (Show More…)	Dec 9 2018, 5:17 PM