Differential D17433

Add a dbus method getWindowInfo returning same data as queryWindowInfo
ClosedPublic
Actions

Authored by graesslin on Dec 8 2018, 4:11 PM.

Details

Reviewers

mart

Group Reviewers

KWin

Commits

R108:9993c6d674b7: Add a dbus method getWindowInfo returning same data as queryWindowInfo

Summary

This dbus method is intended to be used by the kwin rules dialog. KWin
can pass the internal id to the rules dialog through a command line
argument (or similar way) and the dialog can query the information
through the dbus call for the provided id. Thus it's possible to
implement one way to query the information which works on both X11 and
Wayland without any windowing system specific functionality.

Test Plan

See new added integration test

Diff Detail

Repository

R108 KWin

Branch

dbus-get-window-info

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 5823
Build 5841: arc lint + arc unit

graesslin created this revision.Dec 8 2018, 4:11 PM

Restricted Application added a project: KWin. · View Herald TranscriptDec 8 2018, 4:11 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

graesslin requested review of this revision.Dec 8 2018, 4:11 PM

Harbormaster completed remote builds in B5823: Diff 47123.Dec 8 2018, 4:11 PM

mart accepted this revision.Dec 14 2018, 4:04 PM

This revision is now accepted and ready to land.Dec 14 2018, 4:04 PM

Closed by commit R108:9993c6d674b7: Add a dbus method getWindowInfo returning same data as queryWindowInfo (authored by graesslin). · Explain WhyDec 17 2018, 5:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/integration/CMakeLists.txt (1 line)
A	M	autotests/integration/dbus_interface_test.cpp (413 lines)
M		dbusinterface.h (1 line)
M		dbusinterface.cpp (69 lines)
M		org.kde.KWin.xml (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47123	982d7cc		Dec 8 2018, 4:11 PM	★	★
Diff 2	47729	c20be6e	R108:9993c6d674b77677d2d9bca88205c4115812e194	Dec 17 2018, 5:12 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
6a36738da749	24357b195cad	982d7cc4387a	Martin Flöser	Add a dbus method getWindowInfo returning same data as queryWindowInfo (Show More…)	Dec 8 2018, 4:06 PM