Differential D17428

ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very large file
ClosedPublic
Actions

Authored by loh.tar on Dec 8 2018, 1:18 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
VDG
Commits
R40:b1b09ed98ac2: ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very…
R40:5a9fa2358c0c: ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very…
Test Plan

Before


After

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Dec 8 2018, 1:18 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 8 2018, 1:18 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Dec 8 2018, 1:18 PM
loh.tar added a comment.Dec 8 2018, 1:20 PM

That line is a little bit long. Let me know if I should wrap them in shorter pieces.

pino added a subscriber: pino.Dec 8 2018, 1:24 PM

This ought to be backported to Applications/18.12.

cullmann accepted this revision.Dec 8 2018, 5:16 PM
cullmann added a subscriber: cullmann.

I will apply that and backport it, thanks for the fix!

This revision is now accepted and ready to land.Dec 8 2018, 5:16 PM
Closed by commit R40:b1b09ed98ac2: ViewManager: Fix I18n_ARGUMENT_MISSING hint in message box when open a very… (authored by loh.tar, committed by cullmann). · Explain WhyDec 8 2018, 5:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkate/kateviewmanager.cpp (5 lines)

Diff 47132

View Options

kate/kateviewmanager.cpp

Loading...