Differential D17427

[effects] Don't use dynamic_cast
ClosedPublic
Actions

Authored by zzag on Dec 8 2018, 12:56 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:caf0c9386471: [effects] Don't use dynamic_cast
Summary

qobject_cast has several advantages over dynamic_cast:

  • it works without RTTI;
  • it's usually faster.

Also, when it comes to casting QObjects, qobject_cast is de facto
standard.

Diff Detail

Repository
R108 KWin
Branch
simplify-effectwindowimpl-mainwindows
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5810
Build 5828: arc lint + arc unit
zzag created this revision.Dec 8 2018, 12:56 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 8 2018, 12:56 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 8 2018, 12:56 PM
davidedmundson accepted this revision.Dec 8 2018, 12:58 PM
This revision is now accepted and ready to land.Dec 8 2018, 12:58 PM
Closed by commit R108:caf0c9386471: [effects] Don't use dynamic_cast (authored by zzag). · Explain WhyDec 14 2018, 7:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects.cpp (45 lines)

Diff 47099

View Options

effects.cpp

Loading...