You can initialize also all the lists here, because they have default values as well.

If you initialize the list at the beginning, you will not need to have this check and also do this weird thing below. Simply have the first check and otherwise you can do just d->priorityFlowControl[userPriority] = enabled.

Check just if userPriority is < 8.

Same as for setPriorityFlowControl()

Same as for priorityFlowControl()

Same here.

Same here.

Here.

Here.

Also here.

Also here.

Also here.

And last one.

Remove comments.

You can directly assign whole UintList. Same for the rest of options below.

Remove comments.

Shouldn't it save appFcoeMode() instead?

You can probably insert flags all the time.

You can directly push the list there. Same for the lists below.

You are missing Q_DECLARE_FLAGS()

Here it would probably make more sense to accept second parameter as bool.

Make second parameter as bool.

You can use our "UintList" defined data type for these.

something like priorityFlowControl({0, 0, 0, 0, 0, 0, 0, 0, 0}) should work, or not? Same for othe lists.

It should simple by just:

Q_D(DcbSetting)

if (userPriority < 8) {
   d->priorityFlowControl[userPriority] = enabled;
}

Not if you initialize it at the beginning as it should be.

You can have Q_D(DcbSetting) at the beginning of fromMap() function and then instead of setFoo() have d->foo = list.

Oh, right, you don't have methods for that. In that case you can again use Q_D(const DcbSetting) and push there d->priorityFlowControl and others.

Not this way.

This is odd, maybe we should introduce getters and setters for the whole list, this would simplify it and you can use it also in fromMap() and toMap()

Return false.

Return false.

Yeah, that would help.
Do you think I should do that?

Yes please.

Okay, im on it
But on the other hand, it will add 12 functions unnecessarily

Move them please among the rest of methods, so all related methods are next to each other. Also use please "const UintList &list" and do not name the method as setFooList(), they can be just setFoo().

const UintList &list

const UintList &list

const UintList &list

const UintList &list

const UintList &list

const UintList &list

Why? This type is defined in generictypes.h.

Yes, add Q_DECLARE_FLAGS.

Again, this is defined in generictypes.h.

Here as well.

Include not needed.

You can remove the else branch and have just return false.

You can remove the else branch and have just return 0.

You can remove the else branch and have just return 0.

You can remove the else branch and have just return 0.

You can remove the else branch and have just return false.

You can remove the else branch and have just return 0.

I think all those should be added all the time, checking whether the last one is higher can sometime avoid adding them to the map when one of previous ones is set to non-default value.

You don't print priorityBandwith, priororityGroupBandwidth and others.

Rename to DcbFlagType

Please also add Q_DECLARE_OPERATORS_FOR_FLAGS(DcbSetting::DcbFlags)

Remove trailing spaces. They are not visible here, but once I apply this patch, I see them in KDevelop.