KDevelop/PatchReview: polish Purpose integration
ClosedPublic

Authored by rjvbb on Dec 8 2018, 9:10 AM.

Details

Summary

This makes 2 minor changes to the integration with the Purpose framework:

  • sets appropriate initial values to the "Export" model parameters urls and mimeType to avoid startup warnings Cannot initialize model with data QJsonObject() . missing: QJsonValue(string, "urls")
  • sets the updateComment of the Phabricator plugin so that the default upgrade summary is a little more personal.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 5805
Build 5823: arc lint + arc unit
rjvbb requested review of this revision.Dec 8 2018, 9:10 AM
rjvbb created this revision.
apol accepted this revision.Dec 9 2018, 3:05 AM
apol added inline comments.
plugins/patchreview/patchreviewtoolview.cpp
142

i18n?

This revision is now accepted and ready to land.Dec 9 2018, 3:05 AM
This revision was automatically updated to reflect the committed changes.