Add drive-* icons for YaST Partitioner
ClosedPublic

Authored by ndavis on Dec 8 2018, 2:28 AM.

Details

Summary

Add drive-harddisk-encrypted, drive-multidisk, drive-multipartition and drive-partition

These icons are needed by the YaST Partitioner tool. There is currently no 64px version of drive-multipartition because I couldn't come up with any good ideas for it, but a 64px version won't actually be used by YaST Partitioner either.

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Branch
more-harddisk-types (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5873
Build 5891: arc lint + arc unit
ndavis created this revision.Dec 8 2018, 2:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 8 2018, 2:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Dec 8 2018, 2:28 AM
ndavis edited the summary of this revision. (Show Details)Dec 8 2018, 2:42 AM
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the test plan for this revision. (Show Details)Dec 8 2018, 2:45 AM
ndavis edited the summary of this revision. (Show Details)
ndavis edited the summary of this revision. (Show Details)Dec 8 2018, 2:48 AM
ndavis retitled this revision from Add new drive-* icons to Add drive-* icons for YaST Partitioner.
ngraham added a subscriber: ngraham.Dec 8 2018, 4:16 AM

They generally look very good.

I'm wondering if it might be worth it to get rid of those semicircular bumps on the inside for the 16px and maybe even 24px version too. They seem to interfere with any symbol inside the disk at really small sizes.

For drive-multipartition, maybe a disk with lines that make it look like it's internally divided into four pieces?

ndavis added a comment.Dec 8 2018, 5:20 AM

They generally look very good.

I'm wondering if it might be worth it to get rid of those semicircular bumps on the inside for the 16px and maybe even 24px version too. They seem to interfere with any symbol inside the disk at really small sizes.

Get rid of them how? Remove them completely, make the circles solid or make the circles empty? Keep in mind that drive-multipartition is meant to represent LVM and Btrfs, so the tree of partitions makes a bit of sense in that context.

For drive-multipartition, maybe a disk with lines that make it look like it's internally divided into four pieces?

Wasn't quite sure how to do that, so I made this:

For drive-multipartition, maybe a disk with lines that make it look like it's internally divided into four pieces?

Wasn't quite sure how to do that, so I made this:

That looks great!

ndavis added a comment.Dec 9 2018, 6:25 PM

For drive-multipartition, maybe a disk with lines that make it look like it's internally divided into four pieces?

Wasn't quite sure how to do that, so I made this:

That looks great!

Only issue with it is that it looks nothing like the monochrome versions.

Here are some more versions I've been playing with, but nothing looks right:

Maybe the problem is with the monochrome version, not the color one. To me, that "half filled balls connected with struts" icon looks like something more related to chemistry than disk management.

Maybe the problem is with the monochrome version, not the color one. To me, that "half filled balls connected with struts" icon looks like something more related to chemistry than disk management.

How is this? Monochrome icons typically don't use multiple shades of gray or transparency, but some do. Going clockwise, 100%, 67%, 33% and 0% opacity.

How is this? Monochrome icons typically don't use multiple shades of gray or transparency, but some do. Going clockwise, 100%, 67%, 33% and 0% opacity.

Bingo, you've got it! I think that's much better.

ndavis updated this revision to Diff 47232.Dec 10 2018, 5:22 AM

Change monochrome drive-multipartition style and add color version

ndavis updated this revision to Diff 47233.Dec 10 2018, 5:24 AM

Update dark theme

ndavis edited the test plan for this revision. (Show Details)Dec 10 2018, 5:30 AM
ndavis updated this revision to Diff 47234.Dec 10 2018, 5:32 AM

Remove stray point from 64px drive-multipartition

ngraham accepted this revision.Dec 10 2018, 6:19 AM

Looks great now!

This revision is now accepted and ready to land.Dec 10 2018, 6:19 AM
ndavis updated this revision to Diff 47237.Dec 10 2018, 6:32 AM

Add drive-multidisk-symbolic and drive-multipartition-symbolic

This revision was automatically updated to reflect the committed changes.