Details
- Reviewers
amankumargupta jjazeix - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T8495: Money activity, implement keyboard controls.
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/activities/money/MoneyCore.qml | ||
---|---|---|
135 | Needs spaces (parent.height * 1.1). Same for above. | |
140 | Needs space (z: -1) | |
300 | width and height as multiples of 1.1 should be good, as you had done above. Also space needed. | |
305 | Space needed. Refer above. | |
316 | Empty line not needed here. | |
318 | Empty line not needed here. | |
319 | Space needed (items.area.count !== 0) | |
320 | Space needed (items.area.itemAt(items.itemIndex).selected = false) | |
324 | Space needed (items.area = answer) | |
328 | Space needed (items.area = pocket) | |
330 | Space needed. | |
333 | Space needed, and remove extra space, if(items.area.count !==0) { | |
334 | Empty line not needed. | |
335 | Space needed. Same for the statement below. | |
338 | Since you were already using if-else statements above, can you maintain the consistency by replacing the switch case statements with if-else? | |
339 | Extra blank line not needed. | |
341 | Space needed on left of != operator. | |
347 | Space needed. | |
350 | Space needed after = operator. | |
358 | Space needed | |
361 | Empty line not needed. | |
364 | Space needed on sides of = operator | |
366 | Empty line not needed. | |
369 | One extra empty line not needed. | |
src/activities/money/money.js | ||
716 | Space needed on left of = operator. | |
720 | One extra empty line not needed. |
src/activities/money/MoneyCore.qml | ||
---|---|---|
338 | I first tried if-else but that took a lot of lines. Thus, I find switch more consistent than if-else. still, if you want, I will implement it. |