Bump lokalize version to 18.12
ClosedPublic

Authored by sdepiets on Wed, Dec 5, 7:14 AM.

Details

Summary

I'm creating this revision to open a discussion on the lokalize version convention.

It is currently 2.0 both in the application and in the files generated (and has been like that since 2014), having it track the kde apps version would make bugs identification easier.

The only drawback is that the .po commits would be a bit more verbose if some people do not have the latest version.

Diff Detail

Repository
R456 Lokalize
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sdepiets requested review of this revision.Wed, Dec 5, 7:14 AM
sdepiets created this revision.
sdepiets edited the summary of this revision. (Show Details)Wed, Dec 5, 7:17 AM
sdepiets added a reviewer: Localization.
sdepiets added a project: Localization.
yurchor added a subscriber: yurchor.Wed, Dec 5, 9:11 AM

+1

Please change the version in DocBook as well

https://cgit.kde.org/lokalize.git/tree/doc/index.docbook#n30

it should be just

<releaseinfo>Applications 18.12</releaseinfo>

The version should be definitely increased at this point.
As the new de-facto maintainer, I'd say that you can bump the version to whatever version you want.

But:

(if you want more time to think about this, given that the tagging of Applications 18.12 is tomorrow, I'd suggest to bump the version to 2.1 on the Applications/18.12 branch now anyway)

(if you want more time to think about this, given that the tagging of Applications 18.12 is tomorrow, I'd suggest to bump the version to 2.1 on the Applications/18.12 branch now anyway)

it's rather straightforward, I will proceed as you suggested and use cmake versionning

sdepiets updated this revision to Diff 46890.Wed, Dec 5, 10:12 AM

Use cmake versioning

ltoscano added inline comments.Wed, Dec 5, 10:19 AM
CMakeLists.txt
9

I think that this line should be the first one in this file.

sdepiets updated this revision to Diff 46891.Wed, Dec 5, 10:27 AM

Update doc

Restricted Application added a project: Documentation. · View Herald TranscriptWed, Dec 5, 10:27 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript

If this is targeted to Applications/18.12 as I think it is, the doc change would break the freeze. I'd suggest to leave out index.docbook from this change, and only fix it after merging the change into the master branch.

Uhm, the review landed already in the previous version (before some comments) and on master?

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Dec 5, 11:22 AM
This revision was automatically updated to reflect the committed changes.

Uhm, the review landed already in the previous version (before some comments) and on master?

I had some strange behavior on arc, I had to merge manually. I will revert the doc change on 18.12