Install message handler after QApplication
ClosedPublic

Authored by broulik on Mon, Dec 3, 4:06 PM.

Details

Summary

When using qDebug et all we will use Connection::self()->sendMessage to forward that to the browser. Connection uses a QSocketNotifier to listen to browser commands. This requires a working event dispatcher.

When someone uses qDebug before QApplication initialized, e.g. qt5ct does this, our QSocketNotifier is defunct and we never receive any commands from the browser, breaking the extension.

While stdout is reserved for communcation with the browser, where any random debug output will have the browser shut us down, qDebug prints on stderr which can be used for printing debug output, so no file descriptors are closed.

BUG: 400906

Test Plan

Installed qt5ct, export QT_QPA_PLATFORMTHEME=qt5ct, both Chromium and Firefox now show working media controls

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mon, Dec 3, 4:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Dec 3, 4:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mon, Dec 3, 4:06 PM
davidedmundson accepted this revision.Mon, Dec 3, 4:10 PM

Well found!

This revision is now accepted and ready to land.Mon, Dec 3, 4:10 PM
This revision was automatically updated to reflect the committed changes.