Port digital clock settings to QQc2 and Kirigami
ClosedPublic

Authored by mart on Mon, Dec 3, 3:41 PM.

Details

Summary

use QQC2 and FormLayout for alignment

also, qqc2 combobox doesn't suffer from 390801 anymore

BUG: 390801

Test Plan

tried to set all the options

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mon, Dec 3, 3:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Dec 3, 3:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Mon, Dec 3, 3:41 PM
mart added a comment.Mon, Dec 3, 3:41 PM

left old, right new

ngraham added a subscriber: ngraham.Mon, Dec 3, 3:45 PM

The new one doesn't follow the HIG and has poor alignment. Combobox labels are supposed to be to the left of the comboboxes. And having a huge list of checkboxes not aligned to the rest of the controls doesn't look great. This is why we typically add a left label to the top checkbox to serve as a pseudo header for all of them. It's the only way to make the alignment work when you have both checkboxes and other controls in a form layout.

mart added a comment.Mon, Dec 3, 3:48 PM

The new one doesn't follow the HIG and has poor alignment. Combobox labels are supposed to be to the left of the comboboxes. And having a huge list of checkboxes not aligned to the rest of the controls doesn't look great. This is why we typically add a left label to the top checkbox to serve as a pseudo header for all of them. It's the only way to make the alignment work when you have both checkboxes and other controls in a form layout.

hmm, that's as aligned as a formlayout (qml or qwidget) can do.
where are supposed to be the combobox labels? can you mock up?

mart added a comment.Mon, Dec 3, 3:50 PM

ah, like

that can be done only with hacks that will spontaneously break i'm afraid

Here are some examples (in production, from Dolphin's settings window) of how we integrate diverse controls into a form layout and preserve good alignment:




mart added a comment.Mon, Dec 3, 4:00 PM

Here are some examples (in production, from Dolphin's settings window) of how we integrate diverse controls into a form layout and preserve good alignment:

well, in those the comboboxes are aligned with the checkbox and not the checkbox label, as it should be (and as i did)

wrt the excessive spacing between checkbox and checkbox label is a qqc2 issue which i fixed

mart added a comment.Mon, Dec 3, 4:11 PM

i can put information again in front of showdate, tough it conveys misleading and wrong info... i really, really hate this abuse of labels as not-really-sections as the label describes the control standing besides it, not any other

(btw, chiming in as the historyc memory of the usability project, and how the formlayout initially came to be, in the beginning labels of all checkboxes were supposed to be flipped, so all of them on the left (and on the right only the checkbox, without any label)
this was dropped because caused too many flame wars between developers (users were perfectly ok with it)

mart updated this revision to Diff 46799.Mon, Dec 3, 4:22 PM

restore Information: label

ngraham accepted this revision.Mon, Dec 3, 4:34 PM

Much better! I'd want some padding/whitespace between the checkboxes and the radio buttons, and maybe also between the two comboboxes too. But that's probably a judgment call. :)

This revision is now accepted and ready to land.Mon, Dec 3, 4:34 PM
This revision was automatically updated to reflect the committed changes.