Differential D17256

[KUrlNavigator] Fix firstChildUrl when going back from archive
ClosedPublic
Actions

Authored by thsurrel on Nov 30 2018, 12:15 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Frameworks
Commits
R241:84ff71997b30: [KUrlNavigator] Fix firstChildUrl when going back from archive
Summary

When navigating in a archive file in Dolphin and then
using the URL navigator to go back to a parent folder,
the selection was wrong because we were calling
urlSelectionRequested with an URL that still had the
tar: scheme instead of file:.

Test Plan

Navigate in a .zip archive within Dolphin. Click on any
parent folder, the selection should now be on the last
previously opened item (either a foler or the .zip file).

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Nov 30 2018, 12:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 30 2018, 12:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
thsurrel requested review of this revision.Nov 30 2018, 12:15 PM
elvisangelaccio accepted this revision.Dec 1 2018, 3:41 PM
This revision is now accepted and ready to land.Dec 1 2018, 3:41 PM
Closed by commit R241:84ff71997b30: [KUrlNavigator] Fix firstChildUrl when going back from archive (authored by thsurrel). · Explain WhyDec 1 2018, 8:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/kurlnavigator.cpp (3 lines)

Diff 46647

View Options

src/filewidgets/kurlnavigator.cpp

Loading...